Recognize JSON and XML by media type suffixes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
reviewed
Aug 2, 2021
|
can you give some real-world examples of media types which are not currently matched but will be after these changes, please? :) |
|
Searching for |
scop
force-pushed
the
media-type-suffixes
branch
from
2912b9d to
64427bf
Compare
keith-hall
approved these changes
Aug 3, 2021
|
Thanks! Btw, do you want your name in the credits somewhere? as you are a great help with testing and making improvements :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the XML match to after HTML with the assumption that these are processed in order, so that application/xhtml+xml still gets treated as HTML. It seems to for me in bat, but I haven't researched if that's guaranteed to be the case.
The regexps for suffix matching aren't that strict re the main type and beginning of the subtype, so they could match some invalid types. But I guess this would be ok for practical purposes.